[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/retest

some potential flakyness with the usersignup test https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/codeready-toolchain_host-operator/1174/pull-ci-codeready-toolchain-host-operator-master-e2e/1919700868219801600/artifacts/e2e/test/build-log.txt

Let's decide which one we want to merge . With or without the CRDs upgrade.
I'm fine with merging this one and opening a new one for CRD upgrade :)

That's the interesting part. I didn't do anything special. I just pulled your API PR locally and then did "make generate" and this is what I got for the host operator. A clean PR with no CRD changes besides your new configuration field.

So let's merge this clean PR first and then try to find out why you get other unrelated to your API changes in your PR. So it doesn't block us from advancing with the RHDH work.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

That's the interesting part. I didn't do anything special. I just pulled your API PR locally and then did "make generate" and this is what I got for the host operator.

I think things got mixed with the upgrade in between.
My guess is that on my local I had controller-gen already updated, while you ran it with the previous version which didn't cause the update of the CRDs.

I've merged the other one, we can close this. Thank you!

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (c137181) to head (a2b6d56).
Report is 1 commits behind head on master.

@@            Coverage Diff             @@
##           master    #1174      +/-   ##
==========================================
+ Coverage   83.53%   83.56%   +0.02%     
==========================================
  Files          82       82              
  Lines        7927     7927              
==========================================
+ Hits         6622     6624       +2     
+ Misses       1104     1102       -2     
  Partials      201      201